Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The date validator has a different allowBlank validation #105

Open
frykten opened this issue Oct 14, 2021 · 0 comments
Open

The date validator has a different allowBlank validation #105

frykten opened this issue Oct 14, 2021 · 0 comments

Comments

@frykten
Copy link
Contributor

frykten commented Oct 14, 2021

Hi! 👋

While working with ember-changeset-validations, which uses this addon quite extensively, I saw there was an "inconsistency" in the behaviour of the date validator's allowBlank option, which checks nullish values and empty strings instead of using Ember's util isEmpty, as per all other validators (cf.).
I also saw that was introduced when removing Moment (cf. commit). Was it meant to be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant