We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The reorder test helper does not work correctly when a direction is explicitly set.
To Reproduce Steps to reproduce the behavior:
{{sortable-group groupName="closableTabs" direction='x' onChange=@onReorder}}
Expected behavior The new order of the items in the list is the one provided to the reorder helper.
Additional context
<ol data-test-closable-tabs {{sortable-group groupName="closableTabs" direction='x' onChange=@onReorder}} > {{#each @views as |exploration|}} <li {{sortable-item model=exploration groupName="closableTabs"}} data-test-tabs data-test-id="{{exploration.id}}" > ...
import { reorder } from 'ember-sortable/test-support/helpers'; ... await reorder( 'mouse', '[data-test-tabs]', `[data-test-id="${explorations[1].explorationId}"]`, `[data-test-id="${explorations[0].explorationId}"]`, `[data-test-id="${explorations[3].explorationId}"]`, `[data-test-id="${explorations[2].explorationId}"]` );
Workaround
get direction() { if (ENV.environment === 'test') { return; } return 'x'; }
+ {{sortable-group groupName="closableTabs" direction=this.direction onChange=@onReorder}} - {{sortable-group groupName="closableTabs" direction='x' onChange=@onReorder}}
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
The reorder test helper does not work correctly when a direction is explicitly set.
To Reproduce
Steps to reproduce the behavior:
{{sortable-group groupName="closableTabs" direction='x' onChange=@onReorder}}
on a List Element2.Expected behavior
The new order of the items in the list is the one provided to the reorder helper.
Additional context
The Template File
Inside the test logic
Workaround
The text was updated successfully, but these errors were encountered: