Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifiers: dimension are calculated incorrectly if they vary between elements #350

Open
st-h opened this issue Feb 4, 2020 · 0 comments

Comments

@st-h
Copy link
Contributor

st-h commented Feb 4, 2020

Describe the bug
If the sortable elements have different margins, ember-sortable calculates the height of the elements incorrectly, which collapses all margins.

To Reproduce
Use the following css to apply margins to sortable elements
li + li { margin-top: 20px; }

Expected behavior
Existing margins should not collapse.

Additional context
This issue has been noticed using the modifiers version of the add-on.
I tried to find a quick fix, however there seem to more issues within calculating the height of the element. For instance only marginBottom is applied, but no marginTop. Adding marginTop fixed some issue, but introduced new ones, so there probably is another bug with calculating the position correctly.

@st-h st-h changed the title dimension are calculated incorrectly if they vary between elements modifiers: dimension are calculated incorrectly if they vary between elements Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants