Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test helper to open, select date and close the Pikaday #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add test helper to open, select date and close the Pikaday #379

wants to merge 2 commits into from

Conversation

lindyhopchris
Copy link

Pikaday can now be opened, a date selected, and then closed using the fillInDate test helper:

import { fillInDate } from 'ember-pikaday/test-support';

await fillInDate('.my-pikaday-input', new Date(1989, 3, 28));

This is equivalent to:

await click('.my-pikaday-input');
await Interactor.selectDate(new Date(1989, 3, 28));
await closePikaday();

Closes #231

@MelSumner MelSumner self-requested a review January 25, 2024 17:23
@lindyhopchris
Copy link
Author

@MelSumner see you've self-requested a review on this. would be good to get this added to the addon if possible. do you need me to fix the merge conflicts or can you do that easily?

@MelSumner
Copy link
Contributor

@lindyhopchris If you could resolve the conflicts that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner Awaiting requested review from MelSumner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing multiple date pickers
2 participants
@lindyhopchris @MelSumner