Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Documentation #642

Closed
6 tasks done
gossi opened this issue Jan 17, 2022 · 2 comments
Closed
6 tasks done

New Documentation #642

gossi opened this issue Jan 17, 2022 · 2 comments

Comments

@gossi
Copy link
Collaborator

gossi commented Jan 17, 2022

As I "deactivated" ec-addon-docs in #620 - I've looked into alternatives. Solutions available in ember-space are:

Solutions "outside" embers are plenty, such as docusaurus. From the mentioned solutions I've worked with docfy and docusaurus. For this case, I can definitely vote against a solution outside ember. From the remaining I can say docfy is now-that-I-did-that-once great to do, I have no hands-on-experience with empress suite. Both are fine working with markdown files. Carrying over existing documentation will work, examples need to be transformed to the choosen-style.

I personally have done one project in docfy and would do that again for this project. I've used it in combination with picocss and had great results.

Here is the plan to implement this:

[1]: Best practices for docfy is to have this in a monorepo and use one dedicated project for the docs, not to couple it to the tests. Second good point is to use it to prep for addons in v2 format (which look good in monorepo, too).

Automatic Docs Generation

I've looked into automatic documentation generators. So far I've found nothing useful, ie. using api-extractor that would automatically "connect"/be integrated into doc tools isn't there yet. Also api-extractor is questionable to play with exports field in package.json that addon v2 are using. TS team is more on the side of one export per package. There is glimmer-docgen-typescript, but would only document components and leave out a couple of important things for this addon.
Given the API surface of this plugin is luckily quite small, writing this manually with a practial and applicable examples in mind seems the best to do and likely the fastest as well (anyway time is spend in setting up an automation that will take more time than doing it manually).

Even then, as docfy can read markdown files and api-extractor/api-documentor are able to produce them is still able to look for combination in the future.

WDYT ?

@gilest
Copy link
Collaborator

gilest commented Jan 21, 2022

For this case, I can definitely vote against a solution outside ember.

Yes, I think the most ember-integrated solution that is likely to be chosen by the community and maintained for a long time would be ideal.

Automatic Docs

It's a shame (although the generator for ec-addon-docs had its own problems and workarounds) but I suppose we can migrate the in-code docs to the docsite. Certainly we'll have to be more careful to enforce that code changes include updates to the docs.

Monorepo, dummy app separation, v2

Yes, I've been hoping to separate the docsite as the migration to v4 and embroider was quite painful and gave a lot of false negative in the test suite (For example the docsite and deps does not build under v4/embroider but the addon itself is actually compatible).

This was referenced Jan 22, 2022
@gilest gilest pinned this issue Jan 29, 2022
gilest pushed a commit that referenced this issue Feb 21, 2022
First part for #642 - move into a monorepo, here wo go.

There are a couple of config files to be updated to work with that:

renovate.json - untouched, need to see if this works with a monorepo (without a change). Anyway ember-resources has a good renovate config for ember projects
gilest added a commit that referenced this issue Mar 5, 2022
…o README (#721)

Since we don't have a documentation site yet (#642) I've updated the docs markdown files for v5 in-place with links between them. I've also linked to them from the README and added a support matrix table.
@gilest
Copy link
Collaborator

gilest commented Mar 28, 2022

Thanks for your help with this @gossi

@gilest gilest closed this as completed Mar 28, 2022
@gilest gilest unpinned this issue Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants