Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Octane) skipValidate=true in helper does not work #292

Open
dantel35 opened this issue Mar 20, 2021 · 2 comments
Open

(Octane) skipValidate=true in helper does not work #292

dantel35 opened this issue Mar 20, 2021 · 2 comments

Comments

@dantel35
Copy link

Hi,
I am on a freshly created octane ember project with ember-changeset and ember-changeset-validations installed.
I am not sure if this is the same as #147 but passing the skipValidate=true option like documented in ember-changeset:

{{#with (changeset this.model this.AccountValidations skipValidate=true ) as |changesetObj|}}

does not do anything, it is still automatically validating. Doing it manually in JavaScript does work:

 constructor() {
    super(...arguments);
    this.changeset = new Changeset(this.args.model, lookupValidator(AccountValidations), AccountValidations, { skipValidate: true });
  }

Am I doing it wrong or is it still a bug?

@snewcomer
Copy link
Collaborator

@dantel35 👋 I took a look at this and I'm having trouble seeing where the issue might be. Do you have a simple reproduction app I can look at?

@dantel35
Copy link
Author

dantel35 commented Apr 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants