[List] Allow current page to be excluded #2701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ky940819
force-pushed
the
issue/2699
branch
2 times, most recently
from
51826da
to
7bf4936
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
============================================
- Coverage 87.15% 87.06% -0.10%
- Complexity 2692 2695 +3
============================================
Files 235 235
Lines 7188 7199 +11
Branches 1100 1102 +2
============================================
+ Hits 6265 6268 +3
- Misses 365 372 +7
- Partials 558 559 +1 ☔ View full report in Codecov by Sentry. |
|
Can this PR be approved? There are very few cases where List would need to include the current page. |
Adds option to the V4 List component to exclude the current page from the results. ---- fixes adobe#2699
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to the V4 List component to exclude the current page from the results.