Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Experience Fragment inline edit to be consistent with other components #2856

Open
HitmanInWis opened this issue Sep 11, 2024 · 0 comments

Comments

@HitmanInWis
Copy link

The current implementation of "Edit" on an experience fragment component adds the Pencil icon to the component's edit menu after the Parent icon. Authors are accustomed to the "Edit" pencil being the first icon in the list, prior to the Wrench icon. This is how Content Fragment is implemented, which leverages the OOTB capability to register inline editing for a component.

The changes would be as follows:

  • Add the localizedFragmentVariationPath to an HTML attribute
  • Update the editor hook JS to code very similar to the Content Fragment editor hook, using Granite.author.editor.register to register the edit action
  • Update cq:editConfig of Experience Fragment to add the cq:inplaceEditing node referencing the editorType registered in the JS
  • Update cq:editConfig of Experience fragment to remove the cq:actionConfigs that is registering the "custom" editInNewTab action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant