Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make helix-url required #5

Open
davidnuescheler opened this issue Oct 8, 2020 · 2 comments
Open

make helix-url required #5

davidnuescheler opened this issue Oct 8, 2020 · 2 comments

Comments

@davidnuescheler
Copy link
Contributor

that the primary use of the purge action is to purge the outer CDN (and the inner CDN).

i think that keeping the inner CDN in sync with the content/code especially with github is something that needs to happen automatically and in that sense i would rather separate that from this action. i am worried that if we get to a place where we require purging on commits for the inner CDN we will start making the initial hurdle for someone to get started with a helix project higher.

so in my mind this is acceptable complexity for someone who goes live with a helix project on a real domain, but not for someone who is in development.

@tripodsan
Copy link
Collaborator

@davidnuescheler is this a bug/blocker/enhancement ?

@davidnuescheler
Copy link
Contributor Author

davidnuescheler commented Oct 12, 2020

i don't think that it is a blocker, but i find it somewhat undesirable that the default is a config that i think shouldn't even be needed, hence purges things that don't need purging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants