Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning from "Go to program" fails, ends up in Videos #435

Open
dagwieers opened this issue Aug 13, 2019 · 9 comments
Open

Returning from "Go to program" fails, ends up in Videos #435

dagwieers opened this issue Aug 13, 2019 · 9 comments
Labels
bug Something isn't working kodi Related to the Kodi media player merged A fix for this issue has been merged by upstream
Milestone

Comments

@dagwieers
Copy link
Collaborator

Describe the bug

When going back after selecting "Go to program" from the context menu, Kodi doesn't go back to the recent/offline listing but ends up in Kodi's Videos window.

This appears to be a bug in Kodi rather than an add-on issue.

We use the ActivateWindow(window,dir,return) call which should bring you back to the originating listing when you go back.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Recent items or Soon offline listing
  2. Select an episode and right-click, then choose Go to program
  3. In the program episode listing, go back
  4. Notice you end up in Kodi's Videos window

Expected behavior

Kodi should go back to the originating Recent items or Soon offline listing.

Additional context

  • Operating system: LibreELEC v9.0.2
  • Kodi version: v18.2
  • Addon version: v2.2.0
  • Using a VPN: no
  • Country you are using the addon from: BE
@dagwieers dagwieers added bug Something isn't working kodi Related to the Kodi media player reported This issue has been reported to upstream project labels Aug 13, 2019
@dagwieers dagwieers added this to the Future milestone Aug 13, 2019
@dagwieers
Copy link
Collaborator Author

This was reported upstream at: xbmc/xbmc#16492

@dagwieers dagwieers added the help wanted Extra attention is needed label Aug 13, 2019
@dagwieers dagwieers removed this from the Future milestone Aug 20, 2019
@dagwieers
Copy link
Collaborator Author

We implemented a work-around using XBMC.Container.Update(dir).

@dagwieers dagwieers removed the help wanted Extra attention is needed label Oct 21, 2019
@dagwieers dagwieers added this to the v2.3.0 milestone Oct 21, 2019
@dagwieers
Copy link
Collaborator Author

I am going to close this, as I have no hope this will be fixed in Kodi.

@dagwieers dagwieers reopened this May 21, 2020
@dagwieers dagwieers added fixed An upstream fix is available but not yet released and removed reported This issue has been reported to upstream project labels May 21, 2020
@dagwieers
Copy link
Collaborator Author

Thanks to @enen92 there is a fix for this in Kodi: xbmc/xbmc#17893

@mediaminister mediaminister added the merged A fix for this issue has been merged by upstream label Jun 12, 2020
@mediaminister mediaminister removed the fixed An upstream fix is available but not yet released label Jun 12, 2020
@dagwieers
Copy link
Collaborator Author

The merged PR is for Matrix, I proposed it now for Leia as well.

@michaelarnauts
Copy link
Contributor

I am going to close this, as I have no hope this will be fixed in Kodi.

Never stop hoping! :)

@dagwieers
Copy link
Collaborator Author

This has now been merged into the Leia branch !

@dagwieers
Copy link
Collaborator Author

dagwieers commented Oct 14, 2020

@mediaminister I cannot remember, is there a need to go back to using ActivateWindow()? Or do we keep Container.Update().

Related issues:

@mediaminister
Copy link
Collaborator

No, there is no real need to go back to using ActivateWindow(), the current implementation works well enough.

In the past, there were timing issues updating resume points while Kodi Player was closing. But I implemented wait_for_resumepoints and this fixed it. So, most issues and comments regarding container updates before #652 are outdated.

FYI, you can find detailed information about the built-in functions at https://codedocs.xyz/AlwinEsch/kodi/page__list_of_built_in_functions.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kodi Related to the Kodi media player merged A fix for this issue has been merged by upstream
Projects
None yet
Development

No branches or pull requests

3 participants