Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider setting default non zero value for timeout in loop() #142

Open
vladak opened this issue Jan 8, 2023 · 3 comments
Open

consider setting default non zero value for timeout in loop() #142

vladak opened this issue Jan 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@vladak
Copy link
Contributor

vladak commented Jan 8, 2023

Looks like the timeout=0 in loop() caused some unexpected behavior https://forums.adafruit.com/viewtopic.php?p=954996#p954996. Maybe it should be considered setting this to non-zero default ?

@tekktrik
Copy link
Member

It looks like in the sockets that timeout=0 is blocking, which seems different than how CPython handles it. It may be worth changing that to keep compatibility, I'll try to remember to bring it up at the next CircuitPython weekly meeting.

@tekktrik tekktrik added the bug Something isn't working label Jan 12, 2023
@tekktrik
Copy link
Member

Marking as a bug for now because of the above, and at the very least it doesn't do what the docstring says (0 should be non-blocking according to that).

@evilworm
Copy link

see my comment in #138 (comment) as it might solve the issue with timeout=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants