Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Adafruit_Thermal has no destructor method #49

Open
montoyamoraga opened this issue May 8, 2021 · 0 comments · May be fixed by #50
Open

Adafruit_Thermal has no destructor method #49

montoyamoraga opened this issue May 8, 2021 · 0 comments · May be fixed by #50

Comments

@montoyamoraga
Copy link

  • Arduino board: Arduino Nano 33 BLE Sense

  • Arduino IDE version (found in Arduino -> About Arduino menu): 1.8.13

  • List the steps to reproduce the problem below (if possible attach a sketch or
    copy the sketch code in too):

I am using Adafruit Thermal Printer as a dependency on a project, where in a class I have an instance of Adafruit_Thermal, and when I delete this instance on my destructor method, I get the warning "warning: deleting object of polymorphic class type 'Adafruit_Thermal' which has non-virtual destructor might cause undefined behavior".

as far as i know this warning could be fixed with a destructor of Adafruit_Thermal

@montoyamoraga montoyamoraga linked a pull request May 8, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant