Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Delete Edit and Test Icons #271

Open
K-Kumar-01 opened this issue Feb 27, 2021 · 14 comments
Open

Docs for Delete Edit and Test Icons #271

K-Kumar-01 opened this issue Feb 27, 2021 · 14 comments
Labels

Comments

@K-Kumar-01
Copy link
Contributor

Bug Report 🐛

Click on Delete Icon is not working when the cursor hovers over clause templates.
Package: Contract Editor

Expected Behavior

The template should get deleted.

Current Behavior

There is no deletion of the template.

Steps to Reproduce

  1. Hover any template
  2. Click on delete icon

Context (Environment)

Desktop

  • OS: ZorinOs(Ubuntu based)
  • Browser: Chrome
  • Version: Chrome- 88.0.4324.182 (Official Build) (64-bit), Zorin OS 15.3
@jolanglinais
Copy link
Member

This is likely an issue with how the icon is used in our Storybook.

@d-e-v-esh
Copy link
Contributor

@irmerk I don't think that the edit button works either. That button is supposed to let us edit the contract, isn't it?

@lokeshn011101
Copy link

I am trying to resolve this!

@codetheorem
Copy link

Addon action 'delete' is working as it is showing it in the action console.

@d-e-v-esh
Copy link
Contributor

@lokeshn011101 What do you think that the problem is?

@d-e-v-esh
Copy link
Contributor

I can't seem to find where these 3 functions are defined in the code nor the main props of the application. I am not sure if these three functions are defined yet.
Code_Q6kl0n9ca2

The only thing that I could find yet is this.
Code_uLx1oZzzTH

All this does is log stuff on the actions console.

@dselman
Copy link
Contributor

dselman commented Mar 8, 2021

This is working as designed -- these functions can be supplied by the user of the component. They are not implemented by default because they typically require interaction with other components or the persistence layer of the embedding application.

A nice PR would be to update the README with details like this and how to use the component in general.

@jolanglinais jolanglinais added Type: Documentation 📝 Information and guides for clarification and removed Type: Bug 🐛 Something isn't working labels Mar 10, 2021
@jolanglinais jolanglinais changed the title Delete Icon Of Templates Not Working Docs for Delete Edit and Test Icons Mar 10, 2021
@Cronus1007
Copy link
Contributor

@irmerk Shall I work upon this issue.

@Cronus1007
Copy link
Contributor

Cronus1007 commented Mar 15, 2021

@irmerk @dselman Before opening the PR the plan that I am intending to follow is :-

  • First of all the file that I am going to update is link
  • Documenting the role of the user in the Component
  • Documenting how to use them in general.

If some sort of addition or deletions are there let me know.

@jolanglinais
Copy link
Member

@Cronus1007 I believe that sounds like a good plan.

@dezfuture
Copy link

I would like to contribute and fix the issue.
Can you guide me on how should I go forward into solving this issue.

@jolanglinais
Copy link
Member

@dezfuture as you can see, @Cronus1007 is working on this and has an open PR.

@mansigrover09
Copy link

Is this issue resolved?

@mttrbrts
Copy link
Member

No, but there is a solution in #305 if you want to open a new PR. Please consider the feedback given in the thread in #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
10 participants