Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscroll during drag-and-drop of a clause #133

Open
dselman opened this issue Jul 2, 2020 · 17 comments
Open

Autoscroll during drag-and-drop of a clause #133

dselman opened this issue Jul 2, 2020 · 17 comments

Comments

@dselman
Copy link
Contributor

dselman commented Jul 2, 2020

Feature Request 🛍️

Drag-and-drop of clauses within a contract is of limited value, because the contract doesn't autoscroll when you get near the top or the bottom of the visible part of the contract.

Use Case

Create a long contract. Decide you'd like to move a clause from the beginning to the end of the contract.

Possible Solution

Some sort of autoscroll of the contract.

@sanketshevkar
Copy link
Member

Hello @dselman I would like to work on this feature. Is this still open?

@jeromesimeon
Copy link
Member

Hello @dselman I would like to work on this feature. Is this still open?

Hi @sanketshevkar As far as I can tell this is still open. You can test it on the storybook.

https://ap-web-components.netlify.app/?path=/story/contract-editor--contract-editor

I'll assign you. CC @irmerk

@sanketshevkar
Copy link
Member

Ok cool. Thanks @jeromesimeon

@TC5022
Copy link
Contributor

TC5022 commented Dec 3, 2021

Hi @dselman, I would like to work on this issue if it is still open

@Michael-Grover
Copy link

@sanketshevkar are you still working on this issue? If not, I will assign to @TC5022

@TC5022
Copy link
Contributor

TC5022 commented Dec 6, 2021

@sanketshevkar are you working on it?

@jolanglinais jolanglinais added Good First Issue (Taken) and removed Good First Issue :octocat: Good for newcomers labels Dec 6, 2021
@jolanglinais jolanglinais assigned TC5022 and unassigned sanketshevkar Dec 6, 2021
@sanketshevkar
Copy link
Member

Sorry @TC5022 @Michael-Grover. Nope I'm not working on this issue.

@TC5022
Copy link
Contributor

TC5022 commented Dec 8, 2021

@irmerk @Michael-Grover thank you for assigning me the issue. Is it possible to contact you regarding some doubts related to this?

@Michael-Grover
Copy link

Hi @TC5022 , if you have questions, you can put them in this issue

@TC5022
Copy link
Contributor

TC5022 commented Dec 10, 2021

@Michael-Grover @irmerk I think the issue could be solved using the autoscroll-react package but according to their documentation, it uses a ref. So, I am thinking to add the useRef hook. Does it sound good to proceed?

@Michael-Grover
Copy link

Michael-Grover commented Dec 13, 2021

@dselman @DianaLease

@TC5022
Copy link
Contributor

TC5022 commented Dec 21, 2021

The changes I am making in the contract editor code aren't reflected in the storybook. Could you please guide me as to why this is happening? @dselman @DianaLease

@dselman
Copy link
Contributor Author

dselman commented Dec 21, 2021

Did you check the README? I think there are some notes there for what you need to do to rebuild.

@TC5022
Copy link
Contributor

TC5022 commented Dec 21, 2021

Yes i resolved it, there was an issue with my system. Sorry for the trouble.

@jolanglinais
Copy link
Member

Please open a PR when you have something with autoscroll-react so we can review how that could work here.

@TC5022
Copy link
Contributor

TC5022 commented Dec 21, 2021

Sure, I have almost worked up the code. Will open a PR as soon as I get it finalised

@KhushV25
Copy link

Hey Can I work on this or is this solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants