Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames/Changes Not Reflected in Tinfoil #103

Open
mzaki83 opened this issue Aug 17, 2024 · 5 comments
Open

Renames/Changes Not Reflected in Tinfoil #103

mzaki83 opened this issue Aug 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@mzaki83
Copy link

mzaki83 commented Aug 17, 2024

If I rename or move a file, the change is reflected in the ownfoil webgui, but not in Tinfoil. The only way to force the change to propagate to tinfoil is to delete the ownfoil db, restart the docker, and rebuild it from scratch. Not sure if this is a bug or user error.

@a1ex4
Copy link
Owner

a1ex4 commented Aug 17, 2024

What do you mean by "not reflected in Tinfoil"? The game does not appear anymore, or you can select it for installation and you have an error message? In this case which error message? Also did you try closing Tinfoil and opening again? I've found that the "refresh" does not actually make a request to the shop, so the latest status is not reflected after only refreshing.

Also you don't have to delete the ownfoil.db file and restart the container, in the settings you can delete the directory, add it again and run a scan.

@a1ex4 a1ex4 added the waiting for info Issue is waiting for info from users label Aug 17, 2024
@mzaki83
Copy link
Author

mzaki83 commented Aug 18, 2024

For example. I add a file to the monitored folder. The file is instantly added to ownfoil. Then I rename it to add the titleid and version.

in tinfoil on switch, game is not listed, and if I look in files list, it shows up with the original name. Not renamed. Curiously, if I install the file with the old name from the file list, it still downloads and installs. Not sure how this is possible.

Have tried restarting tinfoil. The only thing that seems to force tinfoil to see the new filename is deleting the db, but I will try deleting the directory and adding again next time.

Thanks! Hope I was more clear this time.

@a1ex4
Copy link
Owner

a1ex4 commented Aug 18, 2024

Thanks for the detailed report, there were indeed two bugs:

  1. Tinfoil would not recognize the game if the App ID and version were not in the filename
  2. The filename was not updated in the database after a file was moved, only the complete filepath

I pushed two commits to the develop branch that should fix these two bugs, you can try it by setting the image tag to develop in the docker-compose.

@mzaki83
Copy link
Author

mzaki83 commented Aug 20, 2024

Thank you! I will pull the develop branch and test this evening :)

@a1ex4 a1ex4 added bug Something isn't working and removed waiting for info Issue is waiting for info from users labels Aug 21, 2024
@a1ex4
Copy link
Owner

a1ex4 commented Sep 4, 2024

Fix has been merged into the main branch, you can test it by pulling the latest image also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants