Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Extract import map into a generated JSON file. #1

Open
MicahZoltu opened this issue Dec 8, 2022 · 0 comments
Open

TODO: Extract import map into a generated JSON file. #1

MicahZoltu opened this issue Dec 8, 2022 · 0 comments

Comments

@MicahZoltu
Copy link
Member

Currently, the vendoring script mutates index.html. Instead, index.html should have

<script type='importmap' srcp='./generated/import-map.json'></script>

in it and we should generate import-map.json when running the vendoring script. This way we don't have committed code in the repository.

Only reason this is an issue instead of a PR is because I don't have the time right now to verify this change would work in all browsers and doesn't fail for some reason. If someone wants to do that, would be happy to accept a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant