Here are a few rules to follow in order to ease code reviews, and discussions before maintainers accept and merge your work.
You MUST follow the PSR-2. You always can lint the code by executing bin/coke
.
You MUST run the test suite.
You MUST write (or update) tests.
You SHOULD write documentation.
Please, write commit messages that make sense, and rebase your branch before submitting your Pull Request.
One may ask you to squash your
commits
too. This is used to "clean" your Pull Request before merging it (we want to avoid
commits such as fix tests
, fix 2
, fix 3
, etc.).
Thank you!