-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive search and general fixes #34
base: main
Are you sure you want to change the base?
Conversation
ideally it should be removed
Thanks. Mostly this looks good. I noticed however that (on a desktop screen) the top of the red box around a selected search result gets cropped. If I recall correctly this is what I tried to fix using the offset in I also noticed that the to-from year boxes get miss-aligned when you pull the window into half-screen (again on desktop). I have a sneaky feeling this was always the case but that the extra padding makes it happen slightly earlier. Which bits of #18 is it supposed to fix and which doesn't it (so that I can check and update the issue)? |
I fixed the first issue noted above, it was only appearing in Firefox. Could you provide a screenshot of the miss-aligned inputs, I'm not able to reproduce it on my screen. #18 still there is no zoom out on unfocus otherwise everything should be done, the meta tag might need to be updated to get the media queries to work on actual devices. In the past the map has not even appeared for me on small screens. |
The The issue with the misaligned to-from year boxes I can no longer reproduce so that must have been something caching on my laptop. Now when I make the window half-screen the Search box goes on top of the map as expected. I'll check on my mobile once I've got a usb cable (I can view localhost on the laptop on chrome in my mobile via a usb). |
The rearrangement should now, mobile browsers sets the window width to 960px by default not by the actual screen width. |
|
All common browsers(IE9+) except Opera Mini should be supported.