Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive search and general fixes #34

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Abbe98
Copy link
Contributor

@Abbe98 Abbe98 commented Oct 20, 2016

All common browsers(IE9+) except Opera Mini should be supported.

@lokal-profil
Copy link
Member

Thanks. Mostly this looks good.

I noticed however that (on a desktop screen) the top of the red box around a selected search result gets cropped. If I recall correctly this is what I tried to fix using the offset in onMarkerClick(). I'm guessing the search box has simply gotten slightly higher so the offset is not enough.
(to reproduce: stick "Lars" into the Konstnär field then click on the entry close to Örebro)

I also noticed that the to-from year boxes get miss-aligned when you pull the window into half-screen (again on desktop). I have a sneaky feeling this was always the case but that the extra padding makes it happen slightly earlier.

Which bits of #18 is it supposed to fix and which doesn't it (so that I can check and update the issue)?

@Abbe98
Copy link
Contributor Author

Abbe98 commented Oct 25, 2016

I fixed the first issue noted above, it was only appearing in Firefox.

Could you provide a screenshot of the miss-aligned inputs, I'm not able to reproduce it on my screen.

#18 still there is no zoom out on unfocus otherwise everything should be done, the meta tag might need to be updated to get the media queries to work on actual devices. In the past the map has not even appeared for me on small screens.

@lokal-profil
Copy link
Member

The #searchresults padding needs to be increased to 18.3 for the red line not to be cut (in Firefox). Unfortunately that makes the line above visible in Chrome. =/ On the other hand I checked the version which is live today and that is suffering from the same issue so setting it to 18.3 is good enough for now. I made a comment about the source of the Chrome/Firefox difference over in issue #13.

The issue with the misaligned to-from year boxes I can no longer reproduce so that must have been something caching on my laptop. Now when I make the window half-screen the Search box goes on top of the map as expected.

I'll check on my mobile once I've got a usb cable (I can view localhost on the laptop on chrome in my mobile via a usb).

@lokal-profil
Copy link
Member

I've attached screenshots of what the patch looks like on my mobile (navigating through localhost in Chrome). The gap in the top is the address bar (which you can't hide since you can't scroll, but it looks more weird here than on the mobile). For me the rearrangement of the searchbox does not seem to trigger.
odok_side
odok_standing

I also managed to reproduce the miss-alignment issue. It occurs when I'm on a slightly larger screen where half-screen is just slightly larger than the trigger for screen rearrangement.
missaligned

@Abbe98
Copy link
Contributor Author

Abbe98 commented Nov 9, 2016

The rearrangement should now, mobile browsers sets the window width to 960px by default not by the actual screen width.

@Abbe98
Copy link
Contributor Author

Abbe98 commented Nov 9, 2016

I'm not able to reproduce the miss-alignment issue, instead it's the old issue where fields ends up outside of the viewport(both in Firefox and Opera):
image

@lokal-profil
Copy link
Member

Tried it and it now correctly puts the search bar on top of the map. There are few issues though.

  1. There is a white space between the search results and the map. (minor issue)
    screenshot from 2016-11-10 15-12-29
  2. In portrait mode the map covers the search button.
    screenshot2
  3. If you scroll down to the map you can no longer get back to the search box (since you scroll in the map). Futhermore you cannot even get the url field back.

Are we approaching this the wrong way? Would it be easier to try and detect small-screen devices and give them a completely different layout (or changing the current one for all screens).

@Abbe98
Copy link
Contributor Author

Abbe98 commented Nov 12, 2016

  1. this one I has to look into it's likely that's it's browser specific too. :-/
  2. Okey I just has to make sure the height is never 100% or that there is a back to the top button...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants