Fix a potential deadlock on opening a project (#691)

WPIRoboticsProjects · Oct 25, 2016 · 54d98ea · 54d98ea
1 parent 1d02ed1
commit 54d98ea
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/src/main/java/edu/wpi/grip/core/sockets/SocketImpl.java b/core/src/main/java/edu/wpi/grip/core/sockets/SocketImpl.java
@@ -50,13 +50,15 @@ public SocketHint<T> getSocketHint() {
   }
 
   @Override
-  public synchronized void setValueOptional(Optional<? extends T> optionalValue) {
+  public void setValueOptional(Optional<? extends T> optionalValue) {
     checkNotNull(optionalValue, "The optional value can not be null");
     if (optionalValue.isPresent()) {
       getSocketHint().getType().cast(optionalValue.get());
     }
-    this.value = optionalValue;
-    onValueChanged();
+    synchronized (this) {
+      this.value = optionalValue;
+      onValueChanged();
+    }
     eventBus.post(new SocketChangedEvent(this));
   }