diff --git a/vowpalwabbit/core/src/reduction_stack.cc b/vowpalwabbit/core/src/reduction_stack.cc index 917fde94dab..8dc773dc820 100644 --- a/vowpalwabbit/core/src/reduction_stack.cc +++ b/vowpalwabbit/core/src/reduction_stack.cc @@ -188,12 +188,12 @@ void prepare_reductions(std::vector); reductions.push_back(VW::reductions::topk_setup); reductions.push_back(VW::reductions::oaa_setup); - reductions.push_back(VW::reductions::boosting_setup); reductions.push_back(VW::reductions::ect_setup); reductions.push_back(VW::reductions::log_multi_setup); reductions.push_back(VW::reductions::recall_tree_setup); diff --git a/vowpalwabbit/core/src/reductions/boosting.cc b/vowpalwabbit/core/src/reductions/boosting.cc index 394b4df267b..b514a88d36b 100644 --- a/vowpalwabbit/core/src/reductions/boosting.cc +++ b/vowpalwabbit/core/src/reductions/boosting.cc @@ -110,11 +110,7 @@ void predict_or_learn(boosting& o, VW::LEARNER::learner& base, VW::example& ec) } ec.weight = u; - ec.partial_prediction = final_prediction; - ec.pred.scalar = VW::math::sign(final_prediction); - - if (ld.label == ec.pred.scalar) { ec.loss = 0.; } - else { ec.loss = ec.weight; } + ec.pred.scalar = final_prediction; } //----------------------------------------------------------------- @@ -166,11 +162,7 @@ void predict_or_learn_logistic(boosting& o, VW::LEARNER::learner& base, VW::exam } ec.weight = u; - ec.partial_prediction = final_prediction; - ec.pred.scalar = VW::math::sign(final_prediction); - - if (ld.label == ec.pred.scalar) { ec.loss = 0.; } - else { ec.loss = ec.weight; } + ec.pred.scalar = final_prediction; } template @@ -244,11 +236,7 @@ void predict_or_learn_adaptive(boosting& o, VW::LEARNER::learner& base, VW::exam } ec.weight = u; - ec.partial_prediction = final_prediction; - ec.pred.scalar = VW::math::sign(final_prediction); - - if (ld.label == ec.pred.scalar) { ec.loss = 0.; } - else { ec.loss = ec.weight; } + ec.pred.scalar = final_prediction; } void save_load_sampling(boosting& o, VW::io_buf& model_file, bool read, bool text)