PRs not being sent in for various projects #98
Comments
|
Thanks for reporting! I am having issues getting full logs for Azure, it seems I need to configure logging workspace? This is a bit too complicated, it actually gives you less logs than github actions. |
|
Ok, it all seems complicated to get logs :| Could you maybe try running the ScalaSteward mill plugin locally to see if it breaks? Maybe it's reproducible locally? |
|
Sure, running the So no idea really without actually seeing the logs. |
|
Alright, so I actually just saw that this is happening on another repo. https://github.com/com-lihaoyi/scalatags isn't getting any prs sent in and it's on the |
ckipp01
changed the title
DavidGregory084/mill-tpolecat
|
Ok, I finally managed to get a follow on container logs. Let's see if I find the issue. |
|
Yesterday I only got a part of it and it hasn't yielded any results, I am rerunning the whole job and should get the full logs. |
|
Got it! I think I should actually find all errors and let the people know. |
|
Interestingly for mill-tpolcat it's just this: I can send you the full logs if you want. Packed size is 150 mb and unpacked 10x more 😨 |
|
Ah super helpful, thanks for sharing that. Regarding scalatags and a lot of the other com-lihaoyi ones, the logs make it seem like it's trying to run sbt on them, but looking at them they do indeed have a |
We might need to try and run both 🤔 but that needs a change in the steward I guess. I updated the list, will try tackle that slowly. We can open issues in the repos that are failing. |
|
Ah weird that it failed on Mill. Actually, do you mind dropping me the entire logs thing? I can try to take care of the mill ones. |
|
One of those repos (https://github.com/broadinstitute/poolq) "belongs" to me and I think it should work. I mean, we use it all the time. Also, it doesn't use Mill - it has a regular Anything I can do to help? I'm not sure how to see these logs. |
|
@mtomko I haven't put them anywhere since they're huge and not sure if it's not a security breach to put it up opnely 😅 For your project it seems it's failing because of:
|
That one is related to a recent change: scala-steward-org/scala-steward#2847 |
|
@tgodzik thanks, I probably won't get to it before January but I'm sure I can find a way to work around that; the build should only need those for publishing so maybe I can stub it out or delay initialization |
Yes and no, we actually spoke about this on Discord last night, but the larger issue is that the build still has a |
|
I am ticking off all the repos that either can be removed or are notified. Will try to slowly churn through all of them |
|
Btw. @ckipp01 I see some jobs fail with: is that because of using an older mill version? |
Yea, actually many of the Mill jobs should have greatly been improved since scala-steward-org/scala-steward#2821 was merged. Previously there was no detection of Mill version, so it was sort of best effort if it'd actually work or not. Now that there is an external plugin it correctly identifies the version of Mill and therefore brings in the right plugin. Is that error using the newest steward? |
|
I think we always run the newest steward 🤔 since we use the lastest image |
Weird, do you have an example of a repo that it's failing on. I'll try to reproduce it locally. |
|
That's for example |
This pr just updates a handful of stuff. The reason is that it was failing in the [Steward Runs](VirtusLab/scala-steward-repos#98 (comment)). So this should ensure that the steward plugin doesn't have any issues. Note that I do rip out some of the custom stuff you have for sonatype publishing and just replace it with https://github.com/ckipp01/mill-ci-release mainly because it does almost exactly what you were doing in here. Let me know if that's not ok and I can revert it.
Alright, this should fix it coursier/dependency#16. |
This pr just updates a handful of stuff. The reason is that it was failing in the [Steward Runs](VirtusLab/scala-steward-repos#98 (comment)). So this should ensure that the steward plugin doesn't have any issues. Note that I do rip out some of the custom stuff you have for sonatype publishing and just replace it with https://github.com/ckipp01/mill-ci-release mainly because it does almost exactly what you were doing in here. Let me know if that's not ok and I can revert it.
|
You can tick three checkboxes in the above list after merging #180. Can someone please paste me the log for playframework/play-samples so I can take a look why its failing? Thanks! |
|
@mkurz I added |
|
Looks like it's the same in the container logs: |
|
@AlexITC @tgodzik thanks! I configured and started Scala Steward locally (because I was working on scala-steward-org/scala-steward#2995 anyway) and got exactly the same error. So I went ahead and fixed all problems until I was able to run scala-steward locally against the play-sample repo again:
Now it works! The logs: Click to show the logs...
2023-03-01 08:11:38,081 INFO ──────────── Steward playframework/play-samples ────────────
2023-03-01 08:11:38,081 INFO Check cache of playframework/play-samples
2023-03-01 08:11:38,807 INFO Clone playframework/play-samples
2023-03-01 08:11:40,909 INFO Refresh cache of playframework/play-samples
2023-03-01 08:11:40,949 INFO Parsed repo config {
"commits" : {
"message" : null
},
"pullRequests" : {
"frequency" : null,
"grouping" : [
],
"includeMatchedLabels" : null
},
"scalafmt" : {
"runAfterUpgrading" : null
},
"updates" : {
"pin" : [
],
"allow" : [
],
"allowPreReleases" : [
],
"ignore" : [
],
"limit" : null,
"fileExtensions" : null
},
"postUpdateHooks" : null,
"updatePullRequests" : null,
"buildRoots" : [
"play-java-akka-cluster-example",
"play-java-chatroom-example",
"play-java-compile-di-example",
"play-java-dagger2-example",
"play-java-ebean-example",
"play-java-fileupload-example",
"play-java-forms-example",
"play-java-grpc-example",
"play-java-hello-world-tutorial",
"play-java-jpa-example",
"play-java-rest-api-example",
"play-java-starter-example",
"play-java-streaming-example",
"play-java-telemetry-example",
"play-java-websocket-example",
"play-scala-anorm-example",
"play-scala-chatroom-example",
"play-scala-compile-di-example",
"play-scala-fileupload-example",
"play-scala-forms-example",
"play-scala-grpc-example",
"play-scala-hello-world-tutorial",
"play-scala-isolated-slick-example",
"play-scala-log4j2-example",
"play-scala-macwire-di-example",
"play-scala-rest-api-example",
"play-scala-secure-session-example",
"play-scala-slick-example",
"play-scala-starter-example",
"play-scala-streaming-example",
"play-scala-telemetry-example",
"play-scala-tls-example",
"play-scala-websocket-example"
],
"assignees" : [
],
"reviewers" : [
],
"dependencyOverrides" : [
]
}
2023-03-01 08:11:41,286 INFO Get dependencies in play-java-akka-cluster-example from sbt
2023-03-01 08:11:53,785 INFO Get dependencies in play-java-chatroom-example from sbt
2023-03-01 08:12:05,639 INFO Get dependencies in play-java-compile-di-example from sbt
2023-03-01 08:12:18,200 INFO Get dependencies in play-java-dagger2-example from sbt
2023-03-01 08:12:29,724 INFO Get dependencies in play-java-ebean-example from sbt
2023-03-01 08:12:42,396 INFO Get dependencies in play-java-fileupload-example from sbt
2023-03-01 08:12:53,667 INFO Get dependencies in play-java-forms-example from sbt
2023-03-01 08:13:05,993 INFO Get dependencies in play-java-grpc-example from sbt
2023-03-01 08:13:19,572 INFO Get dependencies in play-java-hello-world-tutorial from sbt
2023-03-01 08:13:31,418 INFO Get dependencies in play-java-jpa-example from sbt
2023-03-01 08:13:43,595 INFO Get dependencies in play-java-rest-api-example from sbt
2023-03-01 08:13:55,749 INFO Get dependencies in play-java-starter-example from sbt
2023-03-01 08:14:07,355 INFO Get dependencies in play-java-streaming-example from sbt
2023-03-01 08:14:19,642 INFO Get dependencies in play-java-telemetry-example from sbt
2023-03-01 08:14:31,713 INFO Get dependencies in play-java-websocket-example from sbt
2023-03-01 08:14:43,862 INFO Get dependencies in play-scala-anorm-example from sbt
2023-03-01 08:14:55,391 INFO Get dependencies in play-scala-chatroom-example from sbt
2023-03-01 08:15:07,303 INFO Get dependencies in play-scala-compile-di-example from sbt
2023-03-01 08:15:19,255 INFO Get dependencies in play-scala-fileupload-example from sbt
2023-03-01 08:15:31,344 INFO Get dependencies in play-scala-forms-example from sbt
2023-03-01 08:15:43,486 INFO Get dependencies in play-scala-grpc-example from sbt
2023-03-01 08:15:56,764 INFO Get dependencies in play-scala-hello-world-tutorial from sbt
2023-03-01 08:16:09,331 INFO Get dependencies in play-scala-isolated-slick-example from sbt
2023-03-01 08:16:23,062 INFO Get dependencies in play-scala-log4j2-example from sbt
2023-03-01 08:16:35,349 INFO Get dependencies in play-scala-macwire-di-example from sbt
2023-03-01 08:16:46,986 INFO Get dependencies in play-scala-rest-api-example from sbt
2023-03-01 08:17:00,000 INFO Get dependencies in play-scala-secure-session-example from sbt
2023-03-01 08:17:11,618 INFO Get dependencies in play-scala-slick-example from sbt
2023-03-01 08:17:24,678 INFO Get dependencies in play-scala-starter-example from sbt
2023-03-01 08:17:36,684 INFO Get dependencies in play-scala-streaming-example from sbt
2023-03-01 08:17:48,619 INFO Get dependencies in play-scala-telemetry-example from sbt
2023-03-01 08:18:00,736 INFO Get dependencies in play-scala-tls-example from sbt
2023-03-01 08:18:13,207 INFO Get dependencies in play-scala-websocket-example from sbt
2023-03-01 08:18:30,345 INFO Find updates for playframework/play-samples
...I think you can tick the Also I think it would be a good idea to somehow catch errors that occur when trying to run scala-steward and notifiy the repo owners about the problem, for example by just automatically open an issue by the scala-steward bot. Thanks! |
|
Ah and btw, maybe give this issue another title? It's not just about mill. If the issue would have had a better title I wouldn't even had opened #179 first... |
tgodzik
changed the title
Thanks! That's changed!
It runs every couple of days since it's a heavy beast and we are rate limited by Github
It should be possible to do inside Scala Steward itself as it has access to Github API already, though I worry it would create a lot of issues currently. |
I wouldn't care about creating lots of issues. IMHO it's more important to let people know that there a problems. People may just rely on the fact they once set up scala-steward and think they are good and forget about it (specially for dependencies that see new releases every couple of years). |
|
@tgodzik Can you please tick |
It shouldn't be removed, that was my mistake. I wanted only to remove archived/deleted repos. And it's ticked! |
|
@tgodzik A bit offtopic, but ScalaSteward v0.23.0 was just released, just curious: when do you usually upgrade you public instance? Asking because the release contains a fix our repos will benefit from. Thanks! |
|
I think we always use the newest image, which has the newest steward. |
|
This one I think https://hub.docker.com/r/fthomas/scala-steward/ |
|
Was this resolved...? |
I can't speak to the larger issue; for the repository I'd commented on, there's not a clear path forward without more build engineering than I have time for, so if it's in the way, I can just submit a PR to remove it from Scala Steward's care. |
|
I haven't had the time to look at all the repositories unfortunately, I was hoping that maybe people with issues on the active repositories would at least be able to see that there is an issue. |
|
Just a short note, that Mill repo itself is not receiving any PRs for a very long time. It's on the |
|
I think the issue previously was that both sbt and mill was present. Is that still the case? I will try to run scala-steward and save all the logs I can. |
This was never the case for Mill. We removed all sbt stuff long time before we used scala-steward. But it might be correct for other |
|
I just tried running my Scala Steward dev instance on |
|
That's probably an issue with all larger projects. What exactly should we cut off? We could make the plugin aware of the buffer length, let it report back to scala-steward and steward needs to run it again. Some kind of paging. But I think this is too complicated. We should either increase the buffer or just support output to files. |
|
The As an FYI to latecomers, the workaround used was to suppress writing to standard-out when running a very verbose set of tests (including a lot of noisy parameterised tests). So if your SBT build forks tests, you could try setting (Test / forkOptions).value
.withOutputStrategy(
OutputStrategy.CustomOutput(OutputStream.nullOutputStream)
)That works for Scalatest test suites, for JUnit5 via the SBT / Jupiter integration you would need something like: testOptions += Tests.Argument(jupiterTestFramework, "-q")I imagine Mill etc have their own ways of doing the same thing. |
I'm not sure if the logs are public or not since I don't see reference to them anywhere, but I noticed today that no PRs are being sent in to https://github.com/DavidGregory084/mill-tpolecat even though it's listed in https://github.com/VirtusLab/scala-steward-repos/blob/main/repos-github.md. Could this be checked to see if it's erroring out on that repo for some reason? If so, pasting the error would be super helpful as I'm happy to look into it.
The text was updated successfully, but these errors were encountered: