Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sensitive data from commit 08153d4 #332

Closed
wants to merge 284 commits into from

Conversation

yelircaasi
Copy link

@yelircaasi yelircaasi commented Apr 13, 2023

Resolves #331.

Changed commit message of 08153d4.

hkupty and others added 30 commits January 24, 2017 19:31
This finishes the toggle work.
When IronRepl is called, if a repl exists, it'll reuse it.
When IronRepl! is called, if a repl exists, it'll override it.
* testing: (35 commits)
  Add visual mappping to `ctr`
  Bump
  Missing nvim param
  Simplified term openning
  Remove unneeded fns
  connect to local repl if present
  Remove extra - moved to zen
  Add `zen` as dependency
  Add bang option to IronRepl
  Make repl toggleable
  Revert "Add return to IronStartRepl function"
  Add return to IronStartRepl function
  Make repl sync
  Even more logs
  Add better logs
  Dump definitions right after opening repl
  Fetch the buffer id directly
  Add back current buffer id to hook calling
  Changes to call_hooks and repl management
  Change var name + fix open closed repl logic
  ...
Add namespace switching for clojure
Document switch-ns functionality
yutkat and others added 15 commits August 29, 2022 14:48
* Remove calls to nvim_err_writeln

Instead use `vim.deprecate` and `error`

* Fix bug of repl not being properly cleaned

* Add indirection to opening new float windows

This allows for functions to be reused to move/reshape float windows

* Add functions for managing the window

This ensures we can move the window around

* Rework view

The intent of this commit is to:
  - Allow for a more fluid split definition
  - Allow for custom sizing (percent and function based)
  - Remove the noise in opening floats
  - Allow for reconfiguring floats

* Sketch implementation of multiple views

* Fix deprecation message

* Add a bit more description to README

* Add documentation to view.lua

* Make helper functions take orientation

So then they're simplified

* Document new view API

* Change default to splits

Ref Vigemus#248
* Allow view API to take options

* Add example for configuring options in windows

* Fix broken fallback to command string

* Fix setting buffer

* Add more examples to readme
Fix nil table for options
* Allow fractions in views

* Add even more docs
* feat: allow to build the repl command using a lua function

This is useful e.g. if the command has to take a path or directory
as an argument.

* feat: pass current buffer to repl command

Co-authored-by: Marc Jakobi <[email protected]>
Co-authored-by: Henry John Kupty <[email protected]>
@yelircaasi yelircaasi changed the title Remove sensitive email address from commit [08153d4](https://github.com/Vigemus/iron.nvim/commit/08153d460db933a8ab118858de05be166805824b) Remove sensitive email address from commit 08153d4 Apr 13, 2023
@yelircaasi yelircaasi closed this Apr 13, 2023
@yelircaasi yelircaasi reopened this Apr 13, 2023
@yelircaasi yelircaasi self-assigned this Apr 13, 2023
@yelircaasi yelircaasi requested review from a team and hkupty April 13, 2023 11:35
@yelircaasi yelircaasi changed the title Remove sensitive email address from commit 08153d4 Remove sensitive data from commit 08153d4 Apr 13, 2023
@hkupty hkupty force-pushed the master branch 2 times, most recently from 3ee7b5b to 792dd11 Compare April 13, 2023 13:22
@mschilli87

This comment was marked as resolved.

@hkupty
Copy link
Collaborator

hkupty commented Apr 13, 2023

@mschilli87 I'm sorry this caused distress and frustration. I'm in no position to judge the severity or impact that "a (one-time, single-line change) contributor not understanding git and/or their company policy" has on this contributor's life.

Having that said, it didn't seem severely alarming in my head as I've seen previous projects doing history rewrites in the past.

Still, I sympathize with your situation and I'll take this in consideration when/if similar measures are needed in the future.

@mschilli87

This comment was marked as resolved.

@hkupty
Copy link
Collaborator

hkupty commented Apr 13, 2023

Thank you for your kind words and once again sorry for the inconvenience. :)

@hkupty
Copy link
Collaborator

hkupty commented Apr 13, 2023

I'll close the pr as the fix is in place already. Thanks a lot for taking the lead, @yelircaasi

@hkupty hkupty closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete my company email address from commit