Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent Fs mismatch in IIR_wAFC full system example #26

Open
produceconsumerobot opened this issue Sep 30, 2020 · 1 comment
Open

Apparent Fs mismatch in IIR_wAFC full system example #26

produceconsumerobot opened this issue Sep 30, 2020 · 1 comment
Assignees
Milestone

Comments

@produceconsumerobot
Copy link

The sampling frequency in the IIR_wAFC in the main ino seems to mismatch the "assumed" rate in filter_coeff_sos.h
I'm not totally clear what the consequences of that would be, but I could imagine the crossover freqs being off by ~10% or something more kooky.

24000 in https://github.com/Tympan/Tympan_Library/blob/master/examples/05-FullSystems/WDRC_3BandIIR_wAFC/filter_coeff_sos.h#L31
vs
22050 in https://github.com/Tympan/Tympan_Library/blob/master/examples/05-FullSystems/WDRC_3BandIIR_wAFC/WDRC_3BandIIR_wAFC.ino#L48

Similar issue in 8 band IIR wAFC

@chipaudette chipaudette self-assigned this Jun 10, 2021
@chipaudette chipaudette added this to the RevE Release milestone Jun 10, 2021
@chipaudette
Copy link
Member

Now that we have an IIR filter block that can calculate it's own coefficients, we need to update these two sketches to simply compute the coefficients for themselves. Then, we avoid the mismatched sample rate.

kxm-creare pushed a commit that referenced this issue Jul 26, 2021
An initial test to verify BC127 BLE functionality and interoperability with iOS devices. Once BLE connections are established, ASCII input from an iOS device should be echo'd back by the Tympan.

Begins: #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants