Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kong2022/examples/readme: set $CBIG_CODE_DIR env missing #26

Open
0nu opened this issue Dec 29, 2021 · 1 comment
Open

Kong2022/examples/readme: set $CBIG_CODE_DIR env missing #26

0nu opened this issue Dec 29, 2021 · 1 comment

Comments

@0nu
Copy link

0nu commented Dec 29, 2021

The $CBIG_CODE_DIR env variable has to be set to (correctly) run KONG2022/examples/CBIG_ArealMSHBM_create_example_input_data.sh. This info is missing in examples/readme.md. If not set, the script doesn't terminate but just throws some warnings and probably copies things to a wrong location.

Might make even more sense to just read the scripts directory via SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) or sth like this.

@rubykong
Copy link

@0nu Thanks for the suggestions! I think I will add a check for this environment variable and throw error messages. Will update in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants