Replies: 1 comment 2 replies
-
No harm in opening the PR - it sounds like a very good speed up, and I'd be very curious personally to see how much more verbose the changes make things. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When I profiled this library I found that parser waste significant amount of time in
reflect
functions.I found some interesting recipies in this post https://stackoverflow.com/a/61858457 and implemented parts 2 and 3 for shared strings and rows types.
In simple benchmark
I've got approx 20-25% better time.
But it brings boilerplate code (error handling, token matching, etc.). Is this result good enough to make pull request and discuss about proposed changes?
Beta Was this translation helpful? Give feedback.
All reactions