Verbose test smell threshold set to 123?

[ishepard]

Hi! Thanks for the tool!
I was looking at the threshold of Verbose Test, and it's currently set to 123 statements. I think this is an error, it seems waaay to high, and also it's kind of a magic number (first 3 numbers of the keyboard). Is it a leftover? What's the correct threshold?

TestSmellDetector/src/main/java/testsmell/smell/VerboseTest.java

Line 61 in 08be07d

final int MAX_STATEMENTS = 123;

[mkaouer]

Hi Davide,
Thank you for taking the time to try the tool.
Indeed any threshold can be definitely optimized either by making it user-defined or by using intelligent (learning from instances labeled by human annotators).
@shehan How did we initialize this threhold?

[jose]

Yep, the implementation of the VerboseTest sounds odd. Here my suggestion on how it could be fixed:

diff --git a/src/main/java/testsmell/smell/VerboseTest.java b/src/main/java/testsmell/smell/VerboseTest.java
index 13b9344..94ae202 100644
--- a/src/main/java/testsmell/smell/VerboseTest.java
+++ b/src/main/java/testsmell/smell/VerboseTest.java
@@ -40,9 +40,7 @@ public class VerboseTest extends AbstractSmell {
     }

     private class ClassVisitor extends VoidVisitorAdapter<Void> {
-        final int MAX_STATEMENTS = 123;
         private MethodDeclaration currentMethod = null;
-        private int verboseCount = 0;
         TestMethod testMethod;

         // examine all methods in the test class
@@ -54,23 +52,21 @@ public class VerboseTest extends AbstractSmell {
                 testMethod.setSmell(false); //default value is false (i.e. no smell)

                 //method should not be abstract
+                int numberOfStatements = 0;
                 if (!currentMethod.isAbstract()) {
                     if (currentMethod.getBody().isPresent()) {
                         //get the total number of statements contained in the method
-                        if (currentMethod.getBody().get().getStatements().size() >= MAX_STATEMENTS) {
-                            verboseCount++;
-                        }
+                        numberOfStatements = currentMethod.getBody().get().getStatements().size();
                     }
                 }
-                boolean isSmelly = verboseCount > thresholds.getVerboseTest();
+                boolean isSmelly = numberOfStatements > thresholds.getVerboseTest();
                 testMethod.setSmell(isSmelly);
-                testMethod.addDataItem("VerboseCount", String.valueOf(verboseCount));
+                testMethod.addDataItem("VerboseCount", String.valueOf(isSmelly ? 1 : 0));

                 smellyElementsSet.add(testMethod);

                 //reset values for next method
                 currentMethod = null;
-                verboseCount = 0;
             }
         }
     }