Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.1] Fix item loss during transfer in Item Conduits #899

Open
wants to merge 2 commits into
base: dev/1.21.1
Choose a base branch
from
Open

[1.21.1] Fix item loss during transfer in Item Conduits #899

wants to merge 2 commits into from

Conversation

DuraBrite
Copy link

  • resolves issue where items were lost during transfer

Description

This PR fixes Issue #898, where items were lost during transfer via item conduits. The fix ensures synchronization between the extracted and inserted item amounts, preventing losses.

Breaking Changes

Adjusted logic in com/enderio/conduits/common/conduit/type/item/ItemConduitTicker.java:79 to account for notInserted values correctly.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Florian Wittek and others added 2 commits November 19, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Items are lost during transfer via Item Conduits
1 participant
@DuraBrite