-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VerifiableCredentialBuilder #400
Comments
since we use UUIDs we'll probably want to update to add the |
@decentralgabe, can I work on a PR to to add this fix if no one is working on it? I've used this repo for a personal projects and I'd like to contribute to the issues. |
@m-rit yes definitely most of the work at TBD has moved to https://github.com/TBD54566975/web5-go, though I still use this SDK sometimes |
I have raised a PR to address the issue, NewVerifiableCredentialBuilder now creates VC with empty ID. Should I add an option argument in the function to aupport VC creation with new uuid (the original behaviour) ? |
@m-rit yes! |
The spec states that
id
is optional. If present, it must be a URL, which may be dereferenced.To better support the spec, we should update the sdk such that:
SetID()
, so it does validation that the parameter is a URI (using theurl.Parse
function).The text was updated successfully, but these errors were encountered: