-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test CI on windows #73
Labels
Comments
@Shikugawa I tried ever on MacOS and it seems to fail too, maybe we need another issue "Build and test CI on macOS"? |
@kezhenxu94 Sounds good. But I'm not sure how to fail build on MacOS. Could you provide logs? |
There are multiple failed cases: With Nothing Modified
With the following patchdiff --git a/.bazelrc b/.bazelrc
index b5e0104..a056e59 100644
--- a/.bazelrc
+++ b/.bazelrc
@@ -1,4 +1,7 @@
build --enable_platform_specific_config
+build --incompatible_require_linker_input_cc_api=false
+build --features=-supports_dynamic_linker
+build:macos --cxxopt=-std=c++17
build:linux --cxxopt=-std=c++17
build:windows --cxxopt=-std:c++17
It still failed when running
OS Info |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is the follow-up of #71. Introduce CI for test on Windows. cc @makefriend8
The text was updated successfully, but these errors were encountered: