Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve more signs when working with function 'split up senses'? #1400

Open
uklomp opened this issue Nov 27, 2024 · 6 comments
Open

Retrieve more signs when working with function 'split up senses'? #1400

uklomp opened this issue Nov 27, 2024 · 6 comments

Comments

@uklomp
Copy link
Collaborator

uklomp commented Nov 27, 2024

Would it be possible to retrieve / analyse about 500 glosses in the function "Split up senses", instead of max 100?
If the answer isn't easy, let's talk about it tomorrow.

@susanodd
Copy link
Collaborator

Okay, , we can see if @Woseseltops has any ideas.

I limited it because there are numerous "operations" on the page. At least on my browsers, it starts to cause there to be too much code. (The things are redrawn dynamically as you edit, so you don't need to reload the page.)
You're right though, it's sometimes hard to construct a query to get a limited result. On the test dataset all the glosses fit on one page.

@Woseseltops
Copy link
Collaborator

Proposal: just try to make it longer. If our browsers explode (the page might to heavy to everything at once) we move to an Ajax-based approach like @susanodd pioneered herself within Signbank.

@susanodd
Copy link
Collaborator

susanodd commented Nov 29, 2024

@Woseseltops This is on signbank-susan now.

[tech stuff]

I can't tell whether the browser is choking on the amount of code. The "debug" of Firefox won't show all the nodes.

Can you try it out @Woseseltops ?

The glosses you can see displayed look fine though, the panels are all there.

I suspect Firefox is truncating. I tried it out with 'all" the NGT glosses to see what would happen.

I made a simple second branch that merely allows 500 results. It does not modify the pagination.
The default pagination is still set to 25 on that branch, but more results can be processed on the page.

@susanodd
Copy link
Collaborator

susanodd commented Nov 29, 2024

@uklomp to clarify, do you want 500 search results, or 500 results per page?

What would be ideal?

It's on signbank-susan now so you can test it.

[tech stuff]

If you want 500 results per page, that requires more work, since the browser chokes. Just limiting it to 500 results is no problem.

The code that is on signbank-susan assumes you want 500 results on a page, so it's like a big worksheet. The code on signbank-susan allows any number of results. (This is for development/testing purposes to see what happens if no limits are imposed.)

I made a second branch that assumes you want the 100 results limit upped to 500 results. This one keeps the same pagination as it is now.

susanodd added a commit that referenced this issue Nov 30, 2024
to prevent browser choking on too many nodes. Firefox truncates results if more than circa 1200
@uklomp
Copy link
Collaborator Author

uklomp commented Dec 3, 2024

Ideally, we get all the results from the search query, and still have the option to show a limited number per page - let's say 50 or 100 per page.

@susanodd
Copy link
Collaborator

susanodd commented Dec 3, 2024

Ideally, we get all the results from the search query, and still have the option to show a limited number per page - let's say 50 or 100 per page.

Okay, that is good to hear for the results per page. That should be possible.

For a technical question about the browser truncating data, I need to ask @Woseseltops. It's a problem with the amount of data per page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants