Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Still Choices When Creating Poster Image #1392

Open
susanodd opened this issue Nov 15, 2024 · 3 comments · Fixed by #1393
Open

Video Still Choices When Creating Poster Image #1392

susanodd opened this issue Nov 15, 2024 · 3 comments · Fixed by #1393
Assignees

Comments

@susanodd
Copy link
Collaborator

susanodd commented Nov 15, 2024

As discussed in Team meeting.

@uklomp This is available on signbank-susan, as a button in Gloss Edit, next to the Create ("middle frame") button that already exists.

(Screenshots: #1393 (comment))

See if the number of images at 15 fps is sufficient to choose from.

Since it takes time to generate the images, and they need to be viewable in the browser, there are two buttons inside the pop-up. One to generate the images and one to show the images. Then you can hover over them to choose. A button at the bottom of the popup is for saving your selection. If you click Dismiss, and exit the modal, you can see the images when you open the modal again. They're deleted after you choose.
@susanodd susanodd self-assigned this Nov 15, 2024
@susanodd susanodd linked a pull request Nov 20, 2024 that will close this issue
susanodd added a commit that referenced this issue Nov 21, 2024
and to add outline to selection. Works on Sarari but includes the radio bullet needed by Safari.
susanodd pushed a commit that referenced this issue Nov 21, 2024
susanodd pushed a commit that referenced this issue Nov 28, 2024
susanodd added a commit that referenced this issue Nov 29, 2024
#1392: Generate still images for video, choose modal
@susanodd susanodd reopened this Nov 29, 2024
@susanodd
Copy link
Collaborator Author

@uklomp this has been deployed to signbank

@uklomp
Copy link
Collaborator

uklomp commented Dec 3, 2024

I think we agreed on not having the multiple buttons (generate still), and also on having less stills, right?
so: when I click 'choose image' I already expect the stills to be there. It's okay if they still need to load (although it would be good to have the text 'images are being loaded' or something like that) but it's not necessary to then still click 'generate' in my opinion.
Then: I asked for 3 stills, you gave me 15 first, but now there are 45. That's too much, because now I need to scroll to see them all and there are too many options. Let's stick to 9 for now, so I can see them in a 3 by 3 display.

@susanodd
Copy link
Collaborator Author

susanodd commented Dec 3, 2024

I think we agreed on not having the multiple buttons (generate still), and also on having less stills, right?
so: when I click 'choose image' I already expect the stills to be there. It's okay if they still need to load (although it would be good to have the text 'images are being loaded' or something like that) but it's not necessary to then still click 'generate' in my opinion.
Then: I asked for 3 stills, you gave me 15 first, but now there are 45. That's too much, because now I need to scroll to see them all and there are too many options. Let's stick to 9 for now, so I can see them in a 3 by 3 display.

The "choose image" is the original button. "Choose still" opens a model. There is only one button inside of the modal.

The number of stills is dependent on the length of the video. If the video is long there are more stills.

(The computer can't know which are the interesting images. If one tries IJSBEER there probably aren't enough since the middle bit is the part between IJS and BEER.)

I will let @Woseseltops decide. He approved it as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants