-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Wordnet to Signbank #1350
Comments
Some problems:
|
Okay I fixed the missing lemmas and descriptions with web scraping the urls that do work. It works, but is probably not really ideal as it takes quite long and there's a risk of too many requests. @Woseseltops @vanlummelhuizen if you have ideas let me know |
@Jetske First a small technical remark/question about your command. In method Global-signbank/signbank/dictionary/management/commands/update_wordnet_links.py Lines 41 to 48 in 2c32b7f
It seems to me you end it prematurely on line 48. If I correctly understand what you are trying to do, I think it boils down to two questions:
Depending on the answers we could find a better solution. |
@vanlummelhuizen Yes, that can probably be done without the 'with' I would say ideally once a day. Everything should be done, as it is meant to update the synsets according to new versions of the different files that are downloaded. Each of these files may contain changes. |
I would add the rest of the code in the method to the with-context simply by indenting it.
Once a day, the whole thing. Then you probably should concentrate on avoiding making too many requests. Down side: the script will take even longer. |
Yes, to prevent too many requests it's probably better to check which links are updated and only edit the synsets in case of changes, rather than what is done now (delete everything and make again). |
@vanlummelhuizen done, now it just deletes the links between glosses and synsets and creates them again. The synsets themselves are not deleted, except if they are not used anymore. Only for new synsets it makes a web scrape request, if it could not be found in wordnet. That should make it much more efficient. |
Add "Wordnet synsets" under senses
https://www.sign-lang.uni-hamburg.de/easier/sign-wordnet/index_ngt.html
E.g.
https://www.sign-lang.uni-hamburg.de/easier/sign-wordnet/sign/ngt.1863.html
this page has a link to signbank -> do this in reverse in signbank, but instead don't link to the gloss but to every synset of that gloss
With a list like this:
The text was updated successfully, but these errors were encountered: