You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code (see code fragment below) is referenced for making the 2-char sub-folders for the dataset videos/images. It's old as can be seen by the omission of explicit exceptions raised. There are/is also an extreme number of try-except clauses. It's also linked to file permission errors if the file system can't create a folder for first two characters of the result returned here.
[MOTIVATION]
This issue is labelled as a BUG because there are "silent" errors going on here. (There are exceptions but those are actually unexpected and actually model/data errors that are not being raised, a gloss that is missing a lemma? a gloss that is not in a dataset? Something probably went wrong during gloss creation.... The gloss is messed up!)
[RELATED BUGS]
This is also related to bugs on the development servers if the "video files" and "subfolders" have never been created on the development servers (where we TEST CODE) raise permission errors, or do not exist. The "paths" exist inside the GlossVideo objects, but actually do not "physically" exist on the servers. This makes it impossible to effectively test the code during development.
[CREATE MOCK FILE SYSTEM ON DEVELOPMENT SERVERS]
Perhaps all the "folder structures" that "exist on the production server" could be created somehow to duplicate it. But put empty video stubs where real videos exist. (To make it possible to actually test the code during development.)
This code (see code fragment below) is referenced for making the 2-char sub-folders for the dataset videos/images. It's old as can be seen by the omission of explicit exceptions raised. There are/is also an extreme number of try-except clauses. It's also linked to file permission errors if the file system can't create a folder for first two characters of the result returned here.
[MOTIVATION]
This issue is labelled as a BUG because there are "silent" errors going on here. (There are exceptions but those are actually unexpected and actually model/data errors that are not being raised, a gloss that is missing a lemma? a gloss that is not in a dataset? Something probably went wrong during gloss creation.... The gloss is messed up!)
[RELATED BUGS]
This is also related to bugs on the development servers if the "video files" and "subfolders" have never been created on the development servers (where we TEST CODE) raise permission errors, or do not exist. The "paths" exist inside the GlossVideo objects, but actually do not "physically" exist on the servers. This makes it impossible to effectively test the code during development.
[CREATE MOCK FILE SYSTEM ON DEVELOPMENT SERVERS]
Perhaps all the "folder structures" that "exist on the production server" could be created somehow to duplicate it. But put empty video stubs where real videos exist. (To make it possible to actually test the code during development.)
[REALLY UGLY CODE]
Global-signbank/signbank/dictionary/models.py
Lines 1250 to 1268 in 7dd05ee
The text was updated successfully, but these errors were encountered: