Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sending v2 Transactions #186

Open
n8maninger opened this issue Oct 17, 2024 · 5 comments
Open

Support Sending v2 Transactions #186

n8maninger opened this issue Oct 17, 2024 · 5 comments
Assignees
Labels
Milestone

Comments

@n8maninger
Copy link
Member

n8maninger commented Oct 17, 2024

The UI currently only supports v1 transactions. It will need to be updated to build and sign v2 transactions after the activation height.

@n8maninger n8maninger added this to Sia Oct 17, 2024
@n8maninger n8maninger moved this to Backlog in Sia Oct 17, 2024
@n8maninger n8maninger added this to the v1.0.0 milestone Oct 17, 2024
@n8maninger
Copy link
Member Author

@alexfreska assigned to you for now. If the Go SDK needs changes, we can create a sub-issue and assign it to one of the backend devs.

@alexfreska
Copy link
Member

@n8maninger do we need support for sending both v1 and v2? Or just migrate the feature to to v2 transactions?

@n8maninger
Copy link
Member Author

We will need to send v1 transactions until the hardfork activates then we can switch to v2

@alexfreska
Copy link
Member

ok, so do we want to add both to the UI, and have it dynamically switch to the v2 flow UI once the consensus height reaches activation height?

@n8maninger
Copy link
Member Author

n8maninger commented Oct 21, 2024

The UX should be transparent to the user. Only the underlying transaction building/signing should change.

if consensus.Index.Height > consensus.Network.HardforkV2.AllowHeight {
  // Instead of `/fund` and `/fund/sf` call `/v2/fund` and `/v2/fund/sf`
  // Use consensus.State.InputSigHash` instead of `WholeTransactionSigHash`
  // Add signatures to V2 transaction type instead of v1
} else {
 // do current stuff
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants