Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing send queue count from WebSocketConnection #78

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

Shane32
Copy link
Owner

@Shane32 Shane32 commented Oct 27, 2024

Allows derived classes to check the send queue count and override SendMessageAsync in case the number of messages in the outbound queue is growing out of control. Perhaps in the future backpressure options will be available as a built-in feature.

@Shane32 Shane32 self-assigned this Oct 27, 2024
Copy link

Coverage Report

Totals Coverage
Statements: 96.96% ( 1882 / 1941 )
Methods: 81.41% ( 289 / 355 )

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11541026324

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 94.537%

Totals Coverage Status
Change from base Build 11540995157: 0.009%
Covered Lines: 1882
Relevant Lines: 1941

💛 - Coveralls

@Shane32 Shane32 merged commit 60a8415 into master Oct 27, 2024
5 checks passed
@Shane32 Shane32 deleted the queuecount branch October 27, 2024 14:05
@Shane32 Shane32 added this to the 6.1.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants