Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests located on abstracts classes are not taken into account #71

Open
tmortagne opened this issue Aug 21, 2018 · 3 comments
Open

Tests located on abstracts classes are not taken into account #71

tmortagne opened this issue Aug 21, 2018 · 3 comments

Comments

@tmortagne
Copy link
Contributor

When running pitest/descartes on the following modules get a very low score because all the test that are located on an abstract class are not taken into account:

  • xwiki-commons-filter-api (tests located in AbstractFilterDescriptorManagerTest)
  • xwiki-commons-cache-infinispan (tests actually located in AbstractEvictionGenericTestCache in module xwiki-commons-cache-tests)

The reason for the abstract is to validate the same features in different cache engines or with different configuration.

@tmortagne
Copy link
Contributor Author

pit-reports.zip
Here is the pit report for xwiki-commons-filter-api

@vmassol
Copy link
Contributor

vmassol commented Aug 21, 2018

@oscarlvp FYI Thomas is a dev on XWiki working with me. I asked him to report this issue which is likely to be an issue from PIT and it's also similar to #53

@tmortagne
Copy link
Contributor Author

Same things with xwiki-platform-security-api but this time the extended class with test come from a dependency (It's Guava MapInterfaceTest which is used to validate that the some Map implementation is doing what it's supposed to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants