Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent build reference in the generated docker-compose file #55

Open
mboussaa opened this issue May 3, 2019 · 4 comments
Open

Comments

@mboussaa
Copy link
Contributor

mboussaa commented May 3, 2019

Characteristics

  • Issue Type: [bug]
  • Reproducibility: [always]
  • Severity: [minor]
  • Tool/Service/Component: [Camp all versions]
  • Execution Environment: [Ubuntu 16.04]
  • Reporter: [[email protected], Mohamed Boussaa]

Description

When generating two configs, it seems that the generated docker-compose file for one of the two generated configs is erroneous.
In the build: parameter of generated compose, the reference to the right dockerfile file is not always correct. It does correctly the changes for one configuration but not for the other.
I had to define the changes manually in camp.yml to make this working as below:

          - targets: [ docker-compose.yml ]
            pattern: "build: ./springpetclinicMS"
            replacements: [ "build: ./images/springpetclinicpg_0" ]  

However, I didn't need to define the replacements for the other config as it was correctly generated, defining the right build reference.

Steps to reproduce

-generate 2 configs.
-check if the the build parameter in the generated dokcer-compose files references to the right dockerfile location.

Other files and URLs

Relationships

Help on issue template

Preview to follow the link or open file .github/ISSUE_DOC.md

@fchauvel
Copy link
Member

fchauvel commented May 3, 2019

Thanks for the feedback.

Is the docker-compose.yml file that is correctly modified, identical to the original one (in the template directory)?

@mboussaa
Copy link
Contributor Author

mboussaa commented May 3, 2019

Hi Frank,

Exactly. You can refer to this project to reproduce the bug: https://github.com/STAMP-project/camp/blob/master/samples/stamp/activeeon/camp.yml#L25

@fchauvel
Copy link
Member

fchauvel commented May 3, 2019

I'll look at it and let you know when I got a fix. Probably early next week.

@fchauvel
Copy link
Member

I'm able to reproduce the problem you have, but unfortunately, fixing it entails deeper changes than I initially thought. We have to think about how and when to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants