Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error]: Breaking change introduced in ver. 9.3.6 (TypeError: split called on null or undefined) #1561

Closed
maverox opened this issue Sep 20, 2024 · 4 comments

Comments

@maverox
Copy link

maverox commented Sep 20, 2024

@SBoudrias,

Breaking change introduced in this commit ec78662#diff-b24d4a707495e5e2f210d200fab3550db18877ded7d01e729bb73e0c9b103c55

I am using node-plop in my project and after this commit I believe I am getting an error on running only the prompts.

    at split (<anonymous>)
    at travel (file:///Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/inquirer/lib/ui/prompt.js:20:10)
    at Object.get (file:///Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/inquirer/lib/ui/prompt.js:27:20)
    at PromptUI.filterIfRunnable (file:///Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/inquirer/lib/ui/prompt.js:159:9)
    at doInnerSub (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/operators/mergeInternals.ts:71:15)
    at outerNext (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/operators/mergeInternals.ts:53:58)
    at OperatorSubscriber.OperatorSubscriber._this._next (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/operators/OperatorSubscriber.ts:70:13)
    at OperatorSubscriber.Subscriber.next (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/Subscriber.ts:75:12)
    at <anonymous> (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/operators/mergeInternals.ts:85:24)
    at OperatorSubscriber.OperatorSubscriber._this._next (/Users/ryan/.npm/_npx/08e24d347c8d5920/node_modules/rxjs/src/internal/operators/OperatorSubscriber.ts:70:13)

I think this is a breaking change

Please look at this issue for more context: plopjs/plop#445

@SBoudrias
Copy link
Owner

name is required for each prompt, do you know why/where is plop passing one with undefined?

That'd help me understand if it's an issue fixing within Inquirer, or if it's a bug plop needs to fix.

@maverox
Copy link
Author

maverox commented Sep 20, 2024

Okay so I was digging into node-plop and it's working and found out that it's only happening when I was using bypassPrompts functionality of runPrompts
but runPrompts method without it is simpling running inquirer which was running fine.

I believe the issue is at node-plop's end.

I would like your remark as to whether this is enough to consider this issue resolved and close this issue .

@SBoudrias
Copy link
Owner

Well I'd like to know someone fixes this on plop side. Seems like it confuses many of their users.

I can push a hotfix to the 9.x release branch.

SBoudrias added a commit that referenced this issue Sep 27, 2024
@SBoudrias
Copy link
Owner

[email protected] includes a fix - but v10 over won't, so plop will need to fix this internally; or explain how that usage is expected (in which case I'm open to review this change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants