Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engage.streaming.rwth-aachen.de iframes in assignment intro aren't downloaded #91

Open
jkhsjdhjs opened this issue Mar 19, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jkhsjdhjs
Copy link

The course Theoretische Informationstechnik 1 contains https://engage.streaming.rwth-aachen.de iframes, which aren't downloaded.
They are contained in the intro property of the respective assignment object:

{
  "id": 16842,
  "fullname": "Theoretische Informationstechnik 1 (VO) [21ws-61.03482]",
  "shortname": "(VO) Theoretische Informationstechnik 1",
  "timemodified": 1644494446,
  "assignments": [
    {
      "id": 29716,
      "cmid": 767824,
      "course": 16842,
      "name": "Übung 02 (28.10.2021)",
      "nosubmissions": 0,
      "submissiondrafts": 0,
      "sendnotifications": 0,
      "sendlatenotifications": 0,
      "sendstudentnotifications": 1,
      "duedate": 0,
      "allowsubmissionsfromdate": 1634853600,
      "grade": 100,
      "timemodified": 1638445053,
      "completionsubmit": 1,
      "cutoffdate": 1635408000,
      "gradingduedate": 0,
      "teamsubmission": 0,
      "requireallteammemberssubmit": 0,
      "teamsubmissiongroupingid": 0,
      "blindmarking": 0,
      "hidegrader": 0,
      "revealidentities": 0,
      "attemptreopenmethod": "none",
      "maxattempts": -1,
      "markingworkflow": 0,
      "markingallocation": 0,
      "requiresubmissionstatement": 0,
      "preventsubmissionnotingroup": 1,
      "configs": [
        {
          "plugin": "file",
          "subtype": "assignsubmission",
          "name": "enabled",
          "value": "1"
        },
        {
          "plugin": "file",
          "subtype": "assignsubmission",
          "name": "maxfilesubmissions",
          "value": "2"
        },
        {
          "plugin": "file",
          "subtype": "assignsubmission",
          "name": "maxsubmissionsizebytes",
          "value": "262144000"
        },
        {
          "plugin": "file",
          "subtype": "assignsubmission",
          "name": "filetypeslist",
          "value": ""
        },
        {
          "plugin": "comments",
          "subtype": "assignsubmission",
          "name": "enabled",
          "value": "1"
        },
        {
          "plugin": "comments",
          "subtype": "assignfeedback",
          "name": "enabled",
          "value": "1"
        },
        {
          "plugin": "comments",
          "subtype": "assignfeedback",
          "name": "commentinline",
          "value": "0"
        },
        {
          "plugin": "editpdf",
          "subtype": "assignfeedback",
          "name": "enabled",
          "value": "1"
        }
      ],
      "intro": "<p dir=\"ltr\" style=\"text-align: left;\">&nbsp;<span class=\"occontainer_outer\">\n  <span class=\"occontainer_inner\">\n    <iframe data-frameSrc=\"https://engage.streaming.rwth-aachen.de/play/664ffa9d-00f3-4c9b-baf0-0b29eb2fd212\" class=\"ocplayer\" allowfullscreen=\"true\"></iframe>\n  </span>\n</span>&nbsp;<br></p>",
      "introformat": 1,
      "introfiles": [],
      "introattachments": [
        {
          "filename": "loesung02.pdf",
          "filepath": "/",
          "filesize": 278975,
          "fileurl": "https://moodle.rwth-aachen.de/webservice/pluginfile.php/1827499/mod_assign/introattachment/0/loesung02.pdf",
          "timemodified": 1635415171,
          "mimetype": "application/pdf",
          "isexternalfile": false
        },
        {
          "filename": "mitschrift.pdf",
          "filepath": "/",
          "filesize": 577983,
          "fileurl": "https://moodle.rwth-aachen.de/webservice/pluginfile.php/1827499/mod_assign/introattachment/0/mitschrift.pdf",
          "timemodified": 1635415171,
          "mimetype": "application/pdf",
          "isexternalfile": false
        },
        {
          "filename": "uebung02.pdf",
          "filepath": "/",
          "filesize": 230409,
          "fileurl": "https://moodle.rwth-aachen.de/webservice/pluginfile.php/1827499/mod_assign/introattachment/0/uebung02.pdf",
          "timemodified": 1634900182,
          "mimetype": "application/pdf",
          "isexternalfile": false
        },
        {
          "filename": "uebung2_video.mp4",
          "filepath": "/",
          "filesize": 32365720,
          "fileurl": "https://moodle.rwth-aachen.de/webservice/pluginfile.php/1827499/mod_assign/introattachment/0/uebung2_video.mp4",
          "timemodified": 1635418476,
          "mimetype": "video/mp4",
          "isexternalfile": false
        }
      ]
    }
  ]
}

(I removed all but one assignment object to keep the output short)

In this case the video is also contained as an attached file named uebung2_video.mp4, but this isn't always the case.

@n0toose n0toose added the enhancement New feature or request label Oct 24, 2022
@n0toose
Copy link
Collaborator

n0toose commented Oct 24, 2022

but this isn't always the case

Hi, sorry for getting back to this issue so late, just wanted to ask if you happen to have any more information as to when that happens.

@n0toose n0toose added the question Further information is requested label Oct 24, 2022
@jkhsjdhjs
Copy link
Author

Thanks for having a look at this issue! I assume that in this case a manager of the course decided to upload the video as uebung2_video.mp4 in addition to the streaming link:

But sadly they didn't always do it, as for exercise 3 there isn't a separate video file:

@n0toose
Copy link
Collaborator

n0toose commented Oct 24, 2022

But sadly they didn't always do it, as for exercise 3 there isn't a separate video file.

Dang it. Yeah, we tend to assume very often that videos do not come with extra attachments.

@n0toose n0toose added bug Something isn't working and removed enhancement New feature or request question Further information is requested labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants