Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] podspec inconsistent naming issue #273

Open
alexp25 opened this issue Jun 9, 2024 · 4 comments
Open

[iOS] podspec inconsistent naming issue #273

alexp25 opened this issue Jun 9, 2024 · 4 comments

Comments

@alexp25
Copy link

alexp25 commented Jun 9, 2024

I encountered an error regarding the name of the podspec, when installing the plugin on iOS.

[error] Analyzing dependencies
        [!] No podspec found for `RevenuecatPurchasesCapacitor` in
        `../../node_modules/@revenuecat/purchases-capacitor`

The problem seems to be because in the RevenueCatPurchasesCapacitor.podspec file, the name is defined as follows: s.name = 'RevenuecatPurchasesCapacitor'

So instead of RevenueCat is referenced as Revenuecat, and in the Podfile of my app where I installed the plugin it gets picked up as Revenuecat but on adding the plugin it gives the above error.

It seems the name must match the .podspec file name. I managed to get it working by renaming the podspec as RevenuecatPurchasesCapacitor.podspec.

I am using version 7.5.9 of the plugin, as I need it to work on Capacitor 5, not 6, so this should probably be fixed in the previous version too.

@RCGitBot
Copy link
Collaborator

RCGitBot commented Jun 9, 2024

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@mshmoustafa
Copy link

Hi @alexp25,

Thanks for reporting this, I've sent a message to our SDK team to look into this.

@mshmoustafa
Copy link

Hey @alexp25,

Just providing an update here. We're evaluating the best way to handle fixing this if appropriate. While the casing is incorrect we want to make sure we don't make any unnecessary breaking changes in the process of fixing it. Seems like macOS and Windows are both case insensitive by default while Linux is case sensitive by default which is why this had gone undetected for a while. For now your workaround of renaming the podspec is fine until we figure out a more permanent solution.

@tonidero
Copy link
Contributor

Hi @alexp25,

Really sorry for the delay on this. We haven't been able to reproduce but we've got a PR that we believe should fix the issue: #292. Would you be able to test the fix on your end?

You should be able to just change the dependency in your package.json from "@revenuecat/purchases-capacitor": "^7.5.9" to "@revenuecat/purchases-capacitor": "git://github.com/RevenueCat/purchases-capacitor.git#rename-podspec-lowercase".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants