-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaywallActivity doesn't implement all methods in PaywallListener #1503
Comments
👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Hi @Xendrez. Thanks for reporting this! Unfortunately, when presenting the paywall as an activity, there is no way to get a result back to the caller activity until the paywall is dismissed, whether after a successful purchase or after the user closes it. We offer that result by using the If you need access to those extra callbacks, currently the only way is to use the Let us know if you have further questions or feedback, it would be greatly appreciated! |
Hi again @Xendrez, we are studying our options for this. One of the main reasons this is not currently possible is that the caller activity will be paused once the paywall acitivity is displayed, so you can't change the UI once these callbacks are called until the paywall activity is called. Could you let us know what would be your use case for the restore callbacks when presenting the paywall as an activity? That might help inform us of missing functionality. Aside from that, thanks to your feedback we also noticed that we currently don't auto-dismiss the paywall upon a restore if the |
I haven't worked on the paywall for some time now. I will give further feedback when I'm back on it, which should be soon. |
PaywallResultHandler works for Cancelled, Error and Purchased. But for Restored, it wont give a result back unless the Cancelled is called. `override fun onActivityResult(result: PaywallResult) {
` |
Hi @angad305,
I'm not sure I fully understand this. Do you mean that you're getting A few questions to try to debug this:
|
Describe the bug
The current PaywallActivity (ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/activity/PaywallActivity.kt) does not implement all the methods in the PaywallListener (ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/PaywallListener.kt). The result is that if the user taps on 'restore', nothing happens. (And nothing can happen as I don't get a result from the Activity). The same is true for the PurchaseError when, for example the user already owns the product.
Environment
Debug logs that reproduce the issue
Steps to reproduce:
Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: