Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

battery: parameterize and apply best practices #1282

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inceptionev
Copy link
Contributor

Description

  • Applies best practices and parameterizes design

  • Bring battery up-to-date

Dependencies that are required for this change

Updates #(issue)

OR

Closes #(issue)

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

Software only:

  • Follows our code style
  • Commented code, particularly in hard-to-understand areas
  • All tests pass - new and old, locally and on CI
  • No new warnings or static check failures
  • Tests that prove fix is effective or new feature works
  • Manual tests are explained, with instructions for reproducing them

CAD / mechanical only:

  • Follows our mechanical engineering standards
  • Everything is metric and ISO where possible
  • All features and constraints are named
  • Imported parts are well-named, with source URL and iProperties
  • Screenshots and/or assembly photos updated

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1282 (efcae3f) into master (fb6eca9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1282   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         102      102           
  Lines        3925     3925           
  Branches      268      268           
=======================================
  Hits         2171     2171           
  Misses       1754     1754           
Flag Coverage Δ
common 51.14% <ø> (ø)
controller 64.03% <ø> (ø)
gui 28.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant