Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inceptionev/experimental nested flow pressure control #1269

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

martukas
Copy link
Member

@martukas martukas commented Jul 4, 2022

Description

Summary of changes

Relevant motivation and context

Dependencies that are required for this change

Updates #(issue)

OR

Closes #(issue)

Self-review checklist:

  • Self-review: looked through the Files changed tab, browsed repository in branch
  • Documentation updated - reflects changes in code, electrical or mechanical design
  • Documentation and graphics follow the documentation style guide
  • New content is linked, easily discoverable, does not require too many clicks
  • Follows other relevant parts of contributor wiki
  • PR has a descriptive name
  • Tagged relevant reviewers

Software only:

  • Follows our code style
  • Commented code, particularly in hard-to-understand areas
  • All tests pass - new and old, locally and on CI
  • No new warnings or static check failures
  • Tests that prove fix is effective or new feature works
  • Manual tests are explained, with instructions for reproducing them

CAD / mechanical only:

  • Follows our mechanical engineering standards
  • Everything is metric and ISO where possible
  • All features and constraints are named
  • Imported parts are well-named, with source URL and iProperties
  • Screenshots and/or assembly photos updated

@martukas martukas force-pushed the inceptionev/experimental_nested_flow-pressure_control branch 2 times, most recently from 7aae050 to f2629b0 Compare July 6, 2022 21:06
@martukas martukas force-pushed the inceptionev/experimental_nested_flow-pressure_control branch from f2629b0 to 1b75acb Compare July 6, 2022 23:06
@martukas martukas force-pushed the inceptionev/experimental_nested_flow-pressure_control branch from 1b75acb to 5a4b6d0 Compare July 6, 2022 23:54
@martukas martukas force-pushed the inceptionev/experimental_nested_flow-pressure_control branch 3 times, most recently from fc24499 to 3780d9d Compare July 7, 2022 08:01
@martukas martukas force-pushed the inceptionev/experimental_nested_flow-pressure_control branch from 3780d9d to b9cd33f Compare July 15, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant