Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate locations when adding bathrooms #399

Open
KurtPrice opened this issue Dec 20, 2017 · 1 comment
Open

Prevent duplicate locations when adding bathrooms #399

KurtPrice opened this issue Dec 20, 2017 · 1 comment
Labels
good first issue Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) ready

Comments

@KurtPrice
Copy link
Contributor

Currently, duplicate bathrooms can be submitted due to very small differences in addresses.
For example: In Bellingham, Wa the restroom in The Black Drop Coffeehouse appears twice because one address is listed as
300 West Champion
and the other restroom as
300 W Champion
There is only one restroom at this location, but it is listed as two separate restrooms, with two separate ratings because of the difference of W vs. West.

Further complications are made by BELLINGHAM vs. Bellingham and WA vs. Washington

These should be a simple fix by reducing all city names to lowercase for comparison and string parsing for W, E, N, S, etc. to their corresponding West, East, North, South, etc.

@Arinzeokeke
Copy link

Yeah, it should ignore case sensitivity for data uniqueness. On the other issue, the workable solution will be to show a confirmation prompt if a new bathroom is too similar to an already saved one.

@DeeDeeG DeeDeeG added Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) and removed Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) labels Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Hacktoberfest These are issues or pull requests related to Hacktoberfest (https://hacktoberfest.digitalocean.com/) ready
Projects
None yet
Development

No branches or pull requests

4 participants