Jobs page filtering functionality #123
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| import { useEffect, useState } from "react"; | ||
|
|
||
| const Filter = ({ setData, filterData }) => { | ||
| // obtaining min and max values for salary range from filterData.js to be set as initial states // | ||
| const minSalaryArray = filterData.map((item) => item.minSalary); | ||
| const minSalaryValue = Math.min(...minSalaryArray); | ||
|
|
||
| const maximumSalaryArray = filterData.map((item) => item.maxSalary); | ||
| const maxSalaryValue = Math.max(...maximumSalaryArray); | ||
|
Comment on lines
+5
to
+9
There was a problem hiding this comment. I love how you took advantage of the built-in Math function of min and max!!🔥 |
||
|
|
||
| const [filter, setFilter] = useState({ | ||
| salary: { | ||
| min: `${minSalaryValue}`, | ||
| max: `${maxSalaryValue}`, | ||
| }, | ||
|
|
||
| location: "", | ||
|
|
@@ -32,14 +39,36 @@ const Filter = () => { | |
| }, | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| setData( | ||
| filterData.filter((item) => { | ||
| if ( | ||
| item.minSalary >= filter.salary.min && | ||
| item.minSalary <= filter.salary.max | ||
| ) { | ||
| return item; | ||
| } | ||
| return null; | ||
| }) | ||
| ); | ||
| }, [filter.salary]); | ||
|
Comment on lines
+44
to
+56
There was a problem hiding this comment. Awesome work on achieving the filtering!! There was a problem hiding this comment. Thank you @AllanSaleh for your continuous support and guidance! I really appreciate your efforts and dedication! Have a lovely day 🙏 |
||
|
|
||
| const locationHandler = (e) => { | ||
| setFilter({ | ||
| ...filter, | ||
| location: e.target.value, | ||
| }); | ||
|
|
||
| setData( | ||
| filterData.filter((item) => { | ||
| if (item.location === e.target.value) { | ||
| return item; | ||
| } | ||
| return null; | ||
| }) | ||
| ); | ||
| }; | ||
|
|
||
| const employmentTypeHandler = (e) => { | ||
|
|
@@ -86,10 +115,9 @@ const Filter = () => { | |
|
|
||
| return ( | ||
| <div className="flex "> | ||
| <div className="bg-gray-200 h-screen p-5 flex flex-col items-center"> | ||
| <h2 className="text-secondary font-bold text-3xl">Filter</h2> | ||
|
|
||
| {/* SALARY */} | ||
| <div className="salary pl-3"> | ||
| <div className="flex space-between pt-3 pb-3 text-center"> | ||
|
|
@@ -145,6 +173,7 @@ const Filter = () => { | |
| fillRule="nonzero" | ||
| /> | ||
| </svg> | ||
| {/* <form onSubmit={handleChangeLocation}> */} | ||
| <select | ||
| className="border border-gray-300 rounded-md text-gray-600 h-10 pl-5 pr-10 bg-white hover:border-gray-400 focus:outline-none appearance-none w-56 " | ||
| value={filter.location} | ||
|
|
@@ -158,6 +187,7 @@ const Filter = () => { | |
| <option>Lebanon</option> | ||
| <option>Kuwait</option> | ||
| </select> | ||
| {/* </form> */} | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
@@ -313,7 +343,6 @@ const Filter = () => { | |
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos to you!!
The component looks nicer now!!