Jobs page filtering functionality #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the first two filters
… component and amended the filterData.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AllanSaleh
approved these changes
Nov 15, 2022
| @@ -8,16 +8,16 @@ function CombiningFilterComponents() { | |||
| const [data, setData] = useState(filterData); | |||
|
|
|||
| return ( | |||
| <div className="App px-7"> | |||
| <div className="App bg-gray-200 px-7 bg-gray-200 "> | |||
There was a problem hiding this comment.
Kudos to you!!
The component looks nicer now!!
Comment on lines
+5
to
+9
| const minSalaryArray = filterData.map((item) => item.minSalary); | ||
| const minSalaryValue = Math.min(...minSalaryArray); | ||
|
|
||
| const maximumSalaryArray = filterData.map((item) => item.maxSalary); | ||
| const maxSalaryValue = Math.max(...maximumSalaryArray); |
There was a problem hiding this comment.
I love how you took advantage of the built-in Math function of min and max!!🔥
This is a very clever way of doing things!👏
Comment on lines
+44
to
+56
| useEffect(() => { | ||
| setData( | ||
| filterData.filter((item) => { | ||
| if ( | ||
| item.minSalary >= filter.salary.min && | ||
| item.minSalary <= filter.salary.max | ||
| ) { | ||
| return item; | ||
| } | ||
| return null; | ||
| }) | ||
| ); | ||
| }, [filter.salary]); |
There was a problem hiding this comment.
Awesome work on achieving the filtering!!
There was a problem hiding this comment.
Thank you @AllanSaleh for your continuous support and guidance! I really appreciate your efforts and dedication! Have a lovely day 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #35 :)
I have also updated the data file to make dealing with data easier!