Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing should be smarter #528

Open
JJ opened this issue Aug 19, 2020 · 0 comments
Open

Testing should be smarter #528

JJ opened this issue Aug 19, 2020 · 0 comments

Comments

@JJ
Copy link
Contributor

JJ commented Aug 19, 2020

Right now, it just looks for new lines and tests them; but it fails in the case lines are deleted, for instance, or in simply other cases where the underlying software is going to be changed.
In that sense, the testing script should also become a module that should be tested independently for all possible cases that might arise. Right now it's not totally clear it's testing correctly, and in many cases (for instance, external dependencies) we just "let it pass" (we have to locally test, anyway). That case is going to be difficult to cover, but in many others it shouldn't

JJ added a commit that referenced this issue Aug 23, 2020
This would close #530.
Additionally, conversion of variables to kebab-case.
And this, again emphasizes the need of #528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant