Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding/margin looks a bit off #37

Open
oystersauce8 opened this issue Oct 1, 2018 · 1 comment
Open

Padding/margin looks a bit off #37

oystersauce8 opened this issue Oct 1, 2018 · 1 comment

Comments

@oystersauce8
Copy link

The padding/margin for the generated bootstrap4 devise forms are not aesthetically pleasing.

I've been tweaking it like this:

cat >> app/assets/stylesheets/1st_load_framework.css.scss << 'eof'
// adjustments to rails_layout generated css
.authform form {
    /* padding-bottom: 40px; */
    padding: 17px 20px;
}

.authform {
    max-width: 400px;
}
// end adjustments to rails_layout generated css
eof
perl -pi -e 's/width:150px/width:150px; margin-top:1vw;/' app/views/devise/sessions/new.html.erb

but hoping me or someone else gets the time to send a PR to address it

@oystersauce8 oystersauce8 changed the title Padding/margin Padding/margin looks a bit off Oct 1, 2018
@oystersauce8
Copy link
Author

would you guys entertain a PR implementing/giving-the-option of "floating labels" for the registration/session/password forms?
I first saw it here -> https://getbootstrap.com/docs/4.0/examples/floating-labels/

And recently I see Netflix (https://www.netflix.com/login)
and Reddit (https://www.reddit.com/login)
also doing it.
/cc @DanielKehoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant