Add diagnostic error output when rvm gemset can't be changed. #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from our discussion on #170. It's not ready to merge yet though. See the "TODO" in the extras recipe. I'm having issues with getting the path of where the
rails_apps_composer new
command is being run, in order to check for the presence of a .rvmrc or .ruby-gemset file in that directory.The problem is using something like
Dir.pwd
from within the extras recipe runs it after the current directory has been changed to the new rails app's directory. And we don't wantFile.dirname(__FILE__)
, since they're not necessarily running the command from the file's directory.I need to add something like this early on before the working directory is changed to the rails app's directory:
...so that we can access it later from the extras recipe. I was thinking of putting it in the RailsWizard::Diagnostics module or somewhere like that, but not sure if that's the best place. Also, the RailsWizard module doesn't seem to be defined within the recipes, I'm guessing from the recipes being run via the erb template or something.