We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composable_kernel/include/ck/utility/amd_smfmac.hpp
Line 19 in a90bfa9
in #1309 This instruction should be built for only gfx94 platforms
The text was updated successfully, but these errors were encountered:
@illsilin our CI should have one stage with GPU_TARGETS of "gfx1100;gfx90a;gfx942" :)
#1358 and #1372 are both for GPU_TARGETS="gfx1100;gfx90a;gfx942"
GPU_TARGETS="gfx1100;gfx90a;gfx942"
How to reproduce:
CXX=/opt/rocm/bin/amdclang++ cmake -DCMAKE_PREFIX_PATH=/opt/rocm -DCMAKE_BUILD_TYPE=Release -DGPU_TARGETS="gfx1100;gfx90a;gfx942" ..
Sorry, something went wrong.
More problem fixed in 4b81c7a
Hence GPU_TARGETS MATCHES is very problematic because it find matches only, excluding other targets based on match is very fragile.
GPU_TARGETS MATCHES
FYI: additional issues are found when building client_example with multiple targets:
client_example
cd ${composable_kernel}/client_example/build CXX=/opt/rocm/llvm/bin/clang++ cmake -DCMAKE_PREFIX_PATH="${composable_kernel}/install/;/opt/rocm/" -DCMAKE_BUILD_TYPE=release -DGPU_TARGETS="gfx1100;gfx90a" -DCMAKE_CXX_FLAGS=" -O3 " .. make -j$(nproc)
will cause problems
/data/driver/composable_kernel/install/include/ck/tensor_operation/gpu/block/blockwise_gemm_xdlops.hpp:171:57: note: expression evaluates to '256 == 128' 171 | static_assert(ThisThreadBlock::GetNumOfThread() == MWaves * NWaves * WaveSize, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated when compiling for gfx1100.
because this above should not be compiled for gfx1100 targets.
gfx1100
meanwhile https://github.com/ROCm/composable_kernel/blob/fix_1371/client_example/25_wrapper/CMakeLists.txt#L5-L10 is problematic because there could be multiple targets by default or such as GPU_TARGETS="gfx1100;gfx90a"
GPU_TARGETS="gfx1100;gfx90a"
jakpiase
illsilin
No branches or pull requests
composable_kernel/include/ck/utility/amd_smfmac.hpp
Line 19 in a90bfa9
in #1309 This instruction should be built for only gfx94 platforms
The text was updated successfully, but these errors were encountered: